[CMake] Include apinotes in StandaloneOverlay.cmake #21928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...because the Darwin overlay is responsible for installing them. Context: Within Apple, overlays are sometimes built separately from the rest of the Swift project. This doesn't currently work with just the public repo (rdar://problem/47324189), but it could, and I broke it with my recent API notes cleanup. This should get things working again. rdar://problem/47294352
|
@swift-ci Please smoke test |
|
(I did check that this works using the Apple-internal repository.) |
|
Failure is an unrelated LLDB timeout… @swift-ci Please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...because the Darwin overlay is responsible for installing them.
Context: Within Apple, overlays are sometimes built separately from the rest of the Swift project. This doesn't currently work with just the public repo (rdar://problem/47324189), but it could, and I broke it with my recent API notes cleanup. This should get things working again.
rdar://problem/47294352