SyntaxNodes: subsume DotSelfExpr and ImplicitMemberExpr by MemberAccessExpr. #21953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
jrose-apple
reviewed
Jan 17, 2019
| token_choices=[ | ||
| 'PeriodToken', 'PrefixPeriodToken' | ||
| ]), | ||
| Child('SelfKeyword', kind='SelfToken'), | ||
| ## Name could be 'self' | ||
| Child("Name", kind='Token'), |
There was a problem hiding this comment.
How do you distinguish foo.self and foo.`self`?
struct Foo {
var `self`: Int { return 0 }
}
let f = Foo()
print(f.self)
print(f.`self`)
There was a problem hiding this comment.
(I mean, yes, hopefully no one does this, but the compiler and language support it.)
There was a problem hiding this comment.
`self` is currently parsed as one token so the structure still applies. It's parsed to be something like: <MemberAccessExpr><IdentifierExpr>f</IdentifierExpr>.`self`</MemberAccessExpr>
There was a problem hiding this comment.
I see, `self` and self are different tokens, even though they have the same identifier text.
|
@swift-ci please smoke test |
nkcsgexi
force-pushed
the
remove-nodes
branch
from
97b9972 to
c9c7fe5
Compare
akyrtzi
approved these changes
Jan 17, 2019
|
@swift-ci please smoke test |
…ssExpr. Per our discussion in another PR, having these three similar nodes at the same time may unnecessarily complicate client side.
nkcsgexi
force-pushed
the
remove-nodes
branch
from
c9c7fe5 to
d4ecf80
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per our discussion in another PR, having these three similar nodes at
the same time may unnecessarily complicate client side.