Skip to content

AST: Cache ProtocolDecl::getInheritedProtocols() #21967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 18, 2019
Merged

AST: Cache ProtocolDecl::getInheritedProtocols() #21967

merged 2 commits into from
Jan 18, 2019

Conversation

slavapestov
Copy link
Contributor

@slavapestov slavapestov commented Jan 18, 2019 •
edited
Loading

Another compile-time performance improvement.

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - b4564fb3c724ad2f16a03119ad895c680aa301c1

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - b4564fb3c724ad2f16a03119ad895c680aa301c1

@slavapestov slavapestov force-pushed the cache-inherited-protocols branch from b4564fb to 144d0ad Compare January 18, 2019 04:18
@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 144d0ad5a4bfce15fee7f47d50576541f4b8c3f2

@slavapestov slavapestov force-pushed the cache-inherited-protocols branch from 144d0ad to c5d0fa3 Compare January 18, 2019 05:11
@slavapestov
Copy link
Contributor Author

@swift-ci Please test

@slavapestov
Copy link
Contributor Author

@swift-ci Please test source compatibility

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 144d0ad5a4bfce15fee7f47d50576541f4b8c3f2

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 144d0ad5a4bfce15fee7f47d50576541f4b8c3f2

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 144d0ad5a4bfce15fee7f47d50576541f4b8c3f2

@slavapestov slavapestov force-pushed the cache-inherited-protocols branch from c5d0fa3 to eef3efb Compare January 18, 2019 20:36
@slavapestov
Copy link
Contributor Author

@swift-ci Please test source compatibility

@slavapestov
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - c5d0fa3f9087e92ff3f4cefcce265200ac77d17e

DougGregor
DougGregor approved these changes Jan 18, 2019
View reviewed changes
Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This rule around associated type lookup is weird, but I suppose we're stuck with it now.

@slavapestov slavapestov merged commit d95861b into swiftlang:master Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slavapestov @swift-ci @DougGregor