Skip to content

AST: Cache ProtocolDecl::getInheritedProtocols() [5.0] #21971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 19, 2019
Merged

AST: Cache ProtocolDecl::getInheritedProtocols() [5.0] #21971

merged 2 commits into from
Jan 19, 2019

Conversation

slavapestov
Copy link
Contributor

Fixes rdar://problem/47371754.

@slavapestov slavapestov requested a review from a team as a code owner January 18, 2019 02:09
@slavapestov
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - abf7789d8c1517ec0a7cf172e50a0a153f364f3b

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - abf7789d8c1517ec0a7cf172e50a0a153f364f3b

DougGregor
DougGregor requested changes Jan 18, 2019
View reviewed changes
include/swift/AST/Decl.h
@@ -514,6 +514,9 @@ class alignas(1 << DeclAlignInBits) Decl {
/// The stage of the circularity check for this protocol.
Circularity : 2,

/// Whether we've computed the inherited protocols list yet.
InheritedProtocolsValid : 1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to set this to false in the constructor!

@slavapestov slavapestov force-pushed the cache-inherited-protocols-5.0 branch from abf7789 to b440b3f Compare January 18, 2019 04:18
@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - abf7789d8c1517ec0a7cf172e50a0a153f364f3b

DougGregor
DougGregor approved these changes Jan 18, 2019
View reviewed changes
@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - abf7789d8c1517ec0a7cf172e50a0a153f364f3b

@slavapestov slavapestov force-pushed the cache-inherited-protocols-5.0 branch from b440b3f to a3a84f3 Compare January 18, 2019 05:36
@slavapestov
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - b440b3fc495cc2e9813c7619ea40bf53cb062a88

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - b440b3fc495cc2e9813c7619ea40bf53cb062a88

@slavapestov slavapestov force-pushed the cache-inherited-protocols-5.0 branch from a3a84f3 to 2460aa7 Compare January 18, 2019 21:42
@slavapestov
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - a3a84f347be9e26c09f928cf1bb99be8ca748d59

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - a3a84f347be9e26c09f928cf1bb99be8ca748d59

@AnnaZaks AnnaZaks merged commit 62cc67a into swiftlang:swift-5.0-branch Jan 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

@AnnaZaks AnnaZaks AnnaZaks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slavapestov @swift-ci @DougGregor @AnnaZaks