[pmo] Eliminate PMOUseKind::PartialStore. #21972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PartialStore is a PMOUseKind that is a vestigal remnant of Definite Init in the PMO source. This can be seen by noting that in Definite Init, PartialStore is how Definite Init diagnoses partially initialized values and errors. In contrast in PMO the semantics of PartialStore are: 1. It can only be produced if we have a raw store use or a copy_addr. 2. We allow for the use to provide an available value just like if it was an assign or an init. 3. We ignore it for the purposes of removing store only allocations since by itself without ownership, stores (and stores from exploded copy_addr) do not effect ownership in any way. Rather than keeping this around, in this commit I review it since it doesn't provide any additional value or [init] or [assign]. Functionally there should be no change.
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PartialStore is a PMOUseKind that is a vestigal remnant of Definite Init in the
PMO source. This can be seen by noting that in Definite Init, PartialStore is
how Definite Init diagnoses partially initialized values and errors. In contrast
in PMO the semantics of PartialStore are:
assign or an init.
itself without ownership, stores (and stores from exploded copy_addr) do not
effect ownership in any way.
Rather than keeping this around, in this commit I review it since it doesn't
provide any additional value or [init] or [assign]. Functionally there should be
no change.