[IRGen] Do not emit ObjC property ivar field when getters and setters are non-trivial. #21976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jrose-apple Hi Jordan, would you take a look at this, please? |
jrose-apple
reviewed
Jan 18, 2019
lib/IRGen/GenClass.cpp
Outdated
| propTy->isTriviallyRepresentableIn(objcLang, propDC); | ||
| bool isStaticBridged = | ||
| ForeignRepresentableKind::StaticBridged == | ||
| propTy->getForeignRepresentableIn(objcLang, propDC).first; |
There was a problem hiding this comment.
I don't think static bridging counts. It looks like we use that for the closure <-> block bridge, and that's still going to be stored as a closure in memory.
…entable types. This patch prevents writing ivar field for ObjC property whose type is not trivially representable in ObjC within its DeclContext. For example, in the case of the property `@objc var foo: String`, it is accessed as an NSString on the ObjC side. Without this patch, this property is backed with an ivar, to which direct accesses would fail. Resolves: SR-9557.
|
Thank you for the feedback, Jordan! I had the code updated. Would you help fire a test, please? |
jrose-apple
approved these changes
Jan 18, 2019
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch prevents writing ivar field for ObjC property whose type is not trivially representable in ObjC within its DeclContext, as spotted by Jordan Rose when reviewing SR-9541.
For example, in the case of the property
@objc var foo: String, it is accessed as anNSStringon the ObjC side. Without this patch, this property is backed with an ivar, to which direct accesses would fail.Resolves SR-9557.
Something I am not confident is how to handle theStaticBridgedproperties (e.g., this one). Being conservative, this patch still emits ivar names in this case.