Basic: set the correct storage class for the alignment #21979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @jrose-apple |
|
@swift-ci please test |
|
"If not MSVC", maybe? Which unfortunately is really "If not (MSVC and not Clang)". |
|
Hmm, I could write that as |
Closed
`cl` objects to the initialization of the templated type differing in storage class due to the indication of `constexpr`. `constexpr` does not give the value itself a `const` storage class. However, because the value is not initialized inline, it does not like the `constexpr` attribute. Apply the `constexpr` only on clang, and correct the storage to `const`.
compnerd
force-pushed
the
storage-class
branch
from
34b85bd to
aa4e9cb
Compare
|
@swift-ci please test |
|
@jrose-apple - okay to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clobjects to the initialization of the templated type differing in storageclass due to the indication of
constexpr.constexprdoes not give the valueitself a
conststorage class. However, because the value is not initializedinline, it does not like the
constexprattribute. Apply theconstexpronlyon clang, and correct the storage to
const.Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.