[sil] Add clarity to how load_weak [take] and store_weak effect an ob… #21985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jects weak ref count.
gottesmm
force-pushed
the
pr-44903c025f4dedd6fcf95759f6512365cd8eb662
branch
from
20c0fae to
cbb3f11
Compare
|
@swift-ci smoke test |
rjmccall
reviewed
Jan 18, 2019
rjmccall
reviewed
Jan 18, 2019
docs/SIL.rst
Outdated
| * The value that was originally referenced by the weak reference will have | ||
| its weak reference count decremented by 1. | ||
| * If the optional is non-nil, the reference in the optional's strong reference count is not | ||
| affected. |
There was a problem hiding this comment.
The "if" clause is unfortunate here; it ends up suggesting that the reference count is affected if the optional is nil, which is of course not what you mean. Just "The new value's weak reference count is incremented, and its strong reference count is not affected." should be clear enough. If you want to be explicit about what happens in the nil case, you should do that for all the places you're modifying.
|
@swift-ci smoke test and merge |
3 similar comments
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…jects weak ref count.