[CSFix] Introduce non-fatal "warning" fixes #21987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intention here is to be able to detect warnings earlier and move some of the logic from CSApply and MiscDiagnostics to solver. Warning fixes still lead to solution being applied to AST.
|
@DougGregor One more reason to do this is - partial application diagnostics - in Swift version < 5 mode such problems should produce a warning in certain cases instead of an error. |
|
@swift-ci please smoke test |
DougGregor
reviewed
Jan 21, 2019
|
@DougGregor Right, I remembered that and including that into my next patch which is going to add first warning :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention here is to be able to detect warnings earlier and
move some of the logic from CSApply and MiscDiagnostics to solver.
Warning fixes still lead to solution being applied to AST.