[AutoDiff] Support differentiating global constant closures. #22004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

rxwei merged 4 commits into swiftlang:tensorflow from rxwei:func-val-global-diff

Jan 20, 2019

Contributor

rxwei commented Jan 20, 2019 •

edited

Loading

When there is a reference to a global let closure, we find its initializer in @main, trace back to the original function_ref, and differentiate that.
NFC: Refactor findReferenceToVisibleFunction and findWitnessMethod to a single template.

Resolves SR-9695.


          [AutoDiff] Support differentiating global constant closures.

* When there is a reference to a global `let` closure, we find its initializer in `@main`, trace back to the original `function_ref`, and differentiate that.

* NFC: Refactor `findReferenceToVisibleFunction` and `findWitnessMethod` to a single template.

rxwei requested a review from dan-zheng

January 20, 2019 00:48

rxwei added 2 commits

January 19, 2019 17:02


          Merge branch 'tensorflow' of github.com:apple/swift into func-val-glo…

4043cac

…bal-diff

* Style up `isInLLDBREPL`.


          Add a global constant closure test that uses tensors.

d4d3206

Contributor Author

rxwei commented Jan 20, 2019

@swift-ci please test tensorflow

dan-zheng approved these changes

View reviewed changes

Contributor

dan-zheng left a comment

Great!


          Add global differentiable closure tests.

11d390c

rxwei added the tensorflow label

Contributor Author

rxwei commented Jan 20, 2019

@swift-ci please test tensorflow

3 similar comments

Contributor Author

rxwei commented Jan 20, 2019

@swift-ci please test tensorflow

Contributor Author

rxwei commented Jan 20, 2019

@swift-ci please test tensorflow

Contributor Author

rxwei commented Jan 20, 2019

@swift-ci please test tensorflow

rxwei merged commit 92cc593 into swiftlang:tensorflow

rxwei deleted the func-val-global-diff branch

January 21, 2019 05:07

rxwei mentioned this pull request

[SR-9695] [AD] global closure func cannot be AD #52135

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels