[SR-9576][SourceKit] Fix syntax type when rethrows is present

[marcelofabri]

Before this patch, SourceKit would return source.lang.swift.syntaxtype.identifier for types in a function if rethrows is present - it should return typeidentifier.

Another issue is that it'd return source.lang.swift.syntaxtype.attribute.builtin for rethrows - I think it should be keyword.

Resolves SR-9576.

cc @nkcsgexi

[nkcsgexi]

Make sense. Thank you for fixing this!

[nkcsgexi]

@swift-ci please smoke test and merge

[marcelofabri]

@nkcsgexi Thanks for reviewing this!

It looks like CI hasn't started, maybe you could try asking it again? 😅

[nkcsgexi]

@swift-ci please smoke test and merge

[marcelofabri]

Just pushed a commit that should fix the test failure. @nkcsgexi can you please trigger CI again?

[nkcsgexi]

Sure @swift-ci please smoke test and merge

[nkcsgexi]

@swift-ci please smoke test and merge

[marcelofabri]

just pushed a new commit that should really fix the tests this time™

[marcelofabri]

@nkcsgexi Can you please trigger CI again? 🙏

[nkcsgexi]

@swift-ci please smoke test

[marcelofabri]

This is finally green ✅

[nkcsgexi]

Great! Merged.

[marcelofabri]

Thanks, @nkcsgexi! Do you think it's worth to cherry-pick this to 5.0 or is it too late in the process?

[nkcsgexi]

No worries. We tend to keep 5.0 branch stable at this point of time. How about we leave it on master and it'll be landed after the next re-branching.