[5.0][Sema] Fix resolveDependentMemberType to properly handle nested typ…
#22021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es found in enum/struct/class Currently if member has been found through same-type constraint it would only be properly handled when it comes from a class type, because that's the only time when base type gets replaced with "concrete" type from equivalence class, but nested types could also come from structs, enums and sometimes protocols (e.g. typealias) which `resolveDependentMemberType` has to handle. Resolves: rdar://problem/47334176 (cherry picked from commit 33cff97)
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@AnnaZaks @DougGregor reviewed original PR for master branch. |
AnnaZaks
approved these changes
Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…es found in enum/struct/class
Currently if member has been found through same-type constraint
it would only be properly handled when it comes from a class type,
because that's the only time when base type gets replaced with
"concrete" type from equivalence class, but nested types could also
come from structs, enums and sometimes protocols (e.g. typealias)
which
resolveDependentMemberTypehas to handle.Resolves: rdar://problem/47334176
(cherry picked from commit 33cff97)