build-script: allow users to specify build-dir under the preset mode. #22065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
gottesmm
reviewed
Jan 23, 2019
| @@ -996,6 +996,9 @@ def main_preset(): | |||
| parser.add_argument( | |||
| "--swiftsyntax-install-prefix", | |||
| help="specify the directory to where SwiftSyntax should be installed") | |||
| parser.add_argument( | |||
| "--build-dir", | |||
| help="specify the directory where build artifact should be stored") | |||
There was a problem hiding this comment.
This already exists. build-subdir. Is that not sufficient?
There was a problem hiding this comment.
It was not accepted in the preset mode like utils/build-script --preset build_swiftsyntax_release --swiftsyntax-install-prefix /tmp/ --build-dir /tmp/build/
There was a problem hiding this comment.
I mean when I combine this flag with a preset name, like ./utils/build-script --preset build_swiftsyntax_release --swiftsyntax-install-prefix /tmp/ --build-dir /tmp/build/
The flag --build-dir /tmp/build/ isn't recognized: build-script: error: unrecognized arguments: --build-dir
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.