[Name lookup] Implement name shadowing rule for Data.withUnsafeBytes. #22074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address an annoying source compatibility issue with the introduction of Data.withUnsafeBytes, which is ambiguous with Swift NIO's implementatio of the same function. Do so with a narrow hackish name shadowing rule (the Swift NIO version shadows the Foundation version) that we will eventually generalize to something sensible. Fixes rdar://problem/46850346.
|
@swift-ci please smoke test and merge |
1 similar comment
|
@swift-ci please smoke test and merge |
ddunbar
reviewed
Jan 24, 2019
| // The Foundation overlay introduced Data.withUnsafeBytes, which is | ||
| // treated as being ambiguous with SwiftNIO's Data.withUnsafeBytes | ||
| // extension. Apply a special-case name shadowing rule to use the | ||
| // latter rather than the former, which be the consequence of a more |
There was a problem hiding this comment.
Indeed it be not English
xedin
added a commit
to xedin/swift-source-compat-suite
that referenced
this pull request
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address an annoying source compatibility issue with the introduction
of Data.withUnsafeBytes, which is ambiguous with Swift NIO's
implementatio of the same function. Do so with a narrow hackish name
shadowing rule (the Swift NIO version shadows the Foundation version)
that we will eventually generalize to something sensible.
Fixes rdar://problem/46850346.