Reserve a vector where we know the size.

[shahzadlone]

Saving reallocation cost (sorry this is too minor but it bothered me that we weren't reserving when we know the size in advance.).

[jrose-apple]

That's fair. I will do the temp. Sorry I am super new to swift code base, could you guide me to where the most time-sensitive code might be? I would love to look at improving some performance critical code =)

I don't think we have one obvious hot spot these days, but things in lib/* are more likely to be part of the compiler proper, and there's a fair amount of code that runs as part of code completion and thus needs to be quick. That said, if you want to get a feel for the code base without necessarily working on performance, I recommend picking one of the unassigned Starter Bugs on our bug tracker.

[shahzadlone]

@jrose-apple Do you need anything else from my side?

[jrose-apple]

Ah, it looks good to me, but this is an area of the code @nkcsgexi is more familiar with, so I wanted him to at least get a chance to look, for all that it's a trivial change.

[shahzadlone]

Is this still in progress?

[CodaFi]

Do you still want us to merge this, or have you moved on to another bug?

[shahzadlone]

This is still a valuable merge. so you should merge this. Anything else I have I will do that in an other PR

[CodaFi]

Alright. I’ll squash this myself

@swift-ci please smoke test

[CodaFi]

⛵️

[shahzadlone]

Thanks for the merge!