Skip to content

Revert "Set a reasonable default for SWIFT_INSTALL_COMPONENTS" #22079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2019
Merged

Revert "Set a reasonable default for SWIFT_INSTALL_COMPONENTS" #22079

merged 1 commit into from
Jan 24, 2019

Conversation

jrose-apple
Copy link
Contributor

Reverts #21886. Something about it broke CMake 3.12.2.1 when configuring from scratch (i.e. no existing CMakeCache.txt in the Swift build dir).

@jrose-apple
Copy link
Contributor Author

@swift-ci Please smoke test

@compnerd
Copy link
Member

@jrose-apple could you provide the error from CMake please? It would be helpful to fix it

@jrose-apple
Copy link
Contributor Author

Assertion failed: (this->NamelinkMode == NamelinkModeNone), function GenerateScriptForConfig, file /[REDACTED]/Sources/CMake/CMake-3.12.2.1/Source/cmInstallTargetGenerator.cxx, line 214.

@jrose-apple jrose-apple merged commit 77689f5 into master Jan 24, 2019
@jrose-apple jrose-apple deleted the revert-21886-install-components-default branch January 24, 2019 03:35
@jrose-apple
Copy link
Contributor Author

(no backtrace or context, happens after "Configuring done", generating for Ninja)

@compnerd
Copy link
Member

Fancy! I divine that this is due to SourceKit XPC trying to build a symlink for the installed framework dylib.

@jrose-apple
Copy link
Contributor Author

*nods* Seems reasonable. CMake 3.12 seems to be stricter about install products in a handful of ways—I was getting complaints about using FILES when I was supposed to use DIRECTORY.

benlangmuir added a commit to benlangmuir/swift that referenced this pull request Jan 29, 2019
@benlangmuir
Re-apply "Set a reasonable default for SWIFT_INSTALL_COMPONENTS"
2d5fbb9 
This reverts commit 77689f5 (swiftlang#22079)
@benlangmuir
Copy link
Contributor

I have a workaround, so I'm re-applying this change in #22193. Cmake bug reported as https://gitlab.kitware.com/cmake/cmake/issues/18848

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrose-apple @compnerd @benlangmuir