[ConstraintSystem] Track AST depth information directly #22082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which is very useful for the solver because otherwise it'd have to compute and store this information twice.
Instead of storing information about expression depths in the solver state (which gets recomputed for salvage) let's track it directly in constraint system, which also gives solver access to it when needed e.g. for fixes.
|
@DougGregor I need to this information available for upcoming partial application diagnostics, because in a lot of cases member resolution happens in CSGen. |
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
|
It also makes more sense to keep this information in constraint system itself instead of threading it through solver state. |
|
Source compat suite failing with vapor/routing UPASS which I opened a separate PR to address. |
|
@swift-ci please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of storing information about expression depths in the
solver state (which gets recomputed for salvage) let's track
it directly in constraint system, which also gives solver
access to it when needed e.g. for fixes.