[Tests] Fix FileCheck prefixes for Driver/linker-clang_rt and update test #22086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Driver/linker-clang_rt test had some of its run lines with incorrect prefixes. (For example, the prefix for the iOS tests was 'IOS' rather than 'CHECK-IOS'). The effect is that the CHECK lines in the test weren't actually used and so little was being tested. The commits updates the --prefix arguments so that the CHECK lines are active. This also updates the test to specify the current behavior: namely that the compiler-rt path is in "/lib/swift/clang/lib/darwin/" rather than "/lib/clang/darwin/". I've also updated one of the tvOS lines to use the "tvos" in the target rather than "ios". I suspect that was typo that wasn't caught the test wasn't running.
|
@jrose-apple Would you be willing to take a look to make sure I've captured the original intent of the test? |
|
@swift-ci Please smoke test |
devincoughlin
changed the title
jrose-apple
approved these changes
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Driver/linker-clang_rt test had some of its run lines with incorrect prefixes.
(For example, the prefix for the iOS tests was 'IOS' rather than 'CHECK-IOS'). The
effect is that the CHECK lines in the test weren't actually used and so little was
being tested.
The commits updates the --prefix arguments so that the CHECK lines are active.
This also updates the test to specify the current behavior: namely that the
compiler-rt path is in "/lib/swift/clang/lib/darwin/" rather than "/lib/clang/darwin/".
I've also updated one of the tvOS lines to use the "tvos" in the target rather than
"ios". I suspect that was typo that wasn't caught the test wasn't running.