Skip to content

[CMake] Remove logic to set unused macro __SWIFT_CURRENT_DYLIB #22105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2019

Conversation

jrose-apple
Copy link
Contributor

Once upon a time we tried to use this to limit the visibility of symbols in the Swift runtime in a way that didn't really make sense. Dave Z removed it last year in #14165.

No functionality change.

Once upon a time we tried to use this to limit the visibility of
symbols in the Swift runtime in a way that didn't really make sense.
Dave Z removed it last year in 9182327.

No functionality change.
@jrose-apple
Copy link
Contributor Author

@swift-ci Please smoke test

@compnerd
Copy link
Member

The value couldn't be compared against anyways, so the value wasn't particularly useful. Good riddance __SWIFT_CURRENT_DYLIB!

@jrose-apple jrose-apple merged commit bad30a5 into swiftlang:master Jan 25, 2019
@jrose-apple jrose-apple deleted the no-longer-current branch January 25, 2019 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants