[5.0] Make SIMD types Codable. #22110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make SIMD types codable. We're considering this a bugfix. This is a very tiny ABI change, in that user-defined SIMD types compiled with an earlier version of 5.0 will be missing the necessary conformance to Codable. Discussed with Ben, and we're OK with this because we don't think there are such types yet, and it can be fixed with a recompile. * Add basic tests
|
@swift-ci please test |
|
Build failed |
|
Build failed |
It looks like JSONEncoder can't round-trip floating-point values on i386 only. Likely an x87 excess-precision bug, but I don't have time to investigate right now. Tracked by https://bugs.swift.org/browse/SR-9759
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
Linux failure unrelated. |
|
@swift-ci please test Linux |
airspeedswift
approved these changes
Jan 25, 2019
…e as JS "integers"
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
These are still breaking on 10.11, so we'll turn them off for now.
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci test |
|
Build failed |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: This is a very tiny ABI change, in that user-defined SIMD types compiled with an earlier version of 5.0 will be missing the necessary conformance to Codable. Discussed with Ben, and we're OK with this because we don't think there are such types yet, and it can be fixed with a recompile. However, because of this consideration we either need to do this in 5.0 or not at all (for now).
Scope: Limited. Adds a common conformance to SIMD types that should be baseline for any new stdlib type. Some adopters may need to remove existing retroactive conformances.
Issue: rdar://problem/47549986
Risk: Low.
Testing: Passed CI testing on master, including new tests for this conformance.
Reviewed by: @airspeedswift (#22092)