Skip to content

[5.0] DynamicReplacement: Don't fail when a library is closed and reloaded #22126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 26, 2019
Merged

[5.0] DynamicReplacement: Don't fail when a library is closed and reloaded #22126

merged 3 commits into from
Jan 26, 2019

Conversation

aschwaighofer
Copy link
Contributor

rdar://47560273

@aschwaighofer aschwaighofer requested a review from a team as a code owner January 25, 2019 22:13
@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test

eeckstein
eeckstein approved these changes Jan 25, 2019
View reviewed changes
Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - a967371

@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - a967371

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - a967371

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - a967371

@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - a7e835c

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - a7e835c

@eeckstein eeckstein merged commit f50ba81 into swiftlang:swift-5.0-branch Jan 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eeckstein eeckstein eeckstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aschwaighofer @swift-ci @eeckstein