[CMake] Remove LINK_LIBRARIES option from _add_swift_executable_single #22128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option has been unused since commit dd85d79. We now use target_link_libraries instead of this option.
|
@swift-ci please test and merge |
|
This may require internal swift cmake sources to be changed. @Rostepher how does this look? |
|
@swift-ci please test Linux platform |
|
@Rostepher Mind taking a quick look at this when you get the chance? |
|
@Rostepher Friendly ping. Could you please look when you have a moment? Thanks! |
|
@Rostepher ping! |
Rostepher
approved these changes
Feb 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option has been unused since commit
dd85d79. We now use
target_link_libraries instead of this option.
cc @gottesmm @compnerd