Skip to content

[test] Add s390x support for test/IRGen/objc_properties_jit.swift #22130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

levivic
Copy link
Contributor

@levivic levivic commented Jan 25, 2019

Typealias type UnderlyingType as Double type in test/Inputs/clang-importer-sdk/swift-modules/CoreGraphics.swift for s390x platform, so that test/IRGen/objc_properties_jit.swift got passed.

Copy link
Contributor

@jrose-apple jrose-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really need that pointer-width #if

Thanks, @levivic!

@jrose-apple jrose-apple self-assigned this Jan 25, 2019
@jrose-apple
Copy link
Contributor

@swift-ci Please smoke test

@compnerd
Copy link
Member

@jrose-apple yeah ... but for now, this is probably as nice as it gets. Going to go ahead and merge this as this is correct and improves things.

@compnerd compnerd merged commit 5bf6d3e into swiftlang:master Jan 26, 2019
@levivic levivic deleted the swift5.0-s390x-objcPropertiesJitTest-fix branch January 28, 2019 14:36
@levivic levivic restored the swift5.0-s390x-objcPropertiesJitTest-fix branch January 28, 2019 18:20
@levivic levivic deleted the swift5.0-s390x-objcPropertiesJitTest-fix branch January 28, 2019 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants