[stdlib] Remove a bunch of declarations marked as obsoleted in 4 #22138

moiseev · 2019-01-25T23:52:56Z

No description provided.

moiseev · 2019-01-25T23:53:04Z

moiseev · 2019-01-25T23:55:02Z

xedin · 2019-01-25T23:55:22Z

test/api-digester/Outputs/stability-stdlib-abi.swift.expected

+Func Int8.<<=(_:_:) has been removed
+Func Int8.>>(_:_:) has been removed
+Func Int8.>>=(_:_:) has been removed
+Func Int8.toUIntMax() has been removed


moiseev · 2019-01-25T23:56:35Z

@swift-ci please smoke test compiler performance

swift-ci · 2019-01-25T23:57:08Z

Build failed
Swift Test Linux Platform
Git Sha - 38603b00e380dda9a7501656261efee244165da2

swift-ci · 2019-01-25T23:58:20Z

Build failed
Swift Test OS X Platform
Git Sha - 38603b00e380dda9a7501656261efee244165da2

swift-ci · 2019-01-26T01:26:11Z

Build comment file:

Summary for master smoketest

Unexpected test results, excluded stats for Kingfisher, Alamofire, ReactiveCocoa

Regressions found (see below)

Debug
- debug brief
- debug detailed
Release
- release brief
- release detailed

Debug

debug brief

Regressed (1)

name	old	new	delta	delta_pct
time.swift-driver.wall	13.9s	14.2s	346.0ms	2.49% ⛔

Improved (0)

name	old	new	delta	delta_pct

Unchanged (delta < 1.0% or delta < 100.0ms) (2)

name	old	new	delta	delta_pct
Frontend.NumInstructionsExecuted	107,262,029,707	107,066,704,241	-195,325,466	-0.18%
LLVM.NumLLVMBytesOutput	6,269,564	6,269,448	-116	-0.0%

debug detailed

Regressed (0)

name	old	new	delta	delta_pct

Improved (2)

name	old	new	delta	delta_pct
Sema.NumDeclsDeserialized	136,209	134,369	-1,840	-1.35% ✅
Sema.NumLazyIterableDeclContexts	24,137	23,867	-270	-1.12% ✅

Unchanged (delta < 1.0% or delta < 100.0ms) (21)

name	old	new	delta	delta_pct
AST.NumImportedExternalDefinitions	1,032	1,032	0	0.0%
AST.NumLoadedModules	828	828	0	0.0%
AST.NumTotalClangImportedEntities	4,210	4,210	0	0.0%
AST.NumUsedConformances	886	886	0	0.0%
IRModule.NumIRBasicBlocks	17,936	17,936	0	0.0%
IRModule.NumIRFunctions	10,554	10,554	0	0.0%
IRModule.NumIRGlobals	8,021	8,021	0	0.0%
IRModule.NumIRInsts	312,280	312,280	0	0.0%
IRModule.NumIRValueSymbols	17,638	17,638	0	0.0%
LLVM.NumLLVMBytesOutput	6,269,564	6,269,448	-116	-0.0%
SILModule.NumSILGenFunctions	5,384	5,384	0	0.0%
SILModule.NumSILOptFunctions	7,062	7,062	0	0.0%
Sema.NumConformancesDeserialized	15,929	15,929	0	0.0%
Sema.NumConstraintScopes	41,654	41,654	0	0.0%
Sema.NumDeclsValidated	11,208	11,208	0	0.0%
Sema.NumFunctionsTypechecked	2,516	2,516	0	0.0%
Sema.NumGenericSignatureBuilders	4,772	4,772	0	0.0%
Sema.NumLazyGenericEnvironments	30,110	29,958	-152	-0.5%
Sema.NumLazyGenericEnvironmentsLoaded	2,012	2,012	0	0.0%
Sema.NumTypesDeserialized	60,919	60,883	-36	-0.06%
Sema.NumTypesValidated	10,932	10,932	0	0.0%

Release

release brief

Regressed (0)

name	old	new	delta	delta_pct

Improved (0)

name	old	new	delta	delta_pct

Unchanged (delta < 1.0% or delta < 100.0ms) (3)

name	old	new	delta	delta_pct
Frontend.NumInstructionsExecuted	140,431,402,073	140,408,951,619	-22,450,454	-0.02%
LLVM.NumLLVMBytesOutput	7,275,652	7,275,780	128	0.0%
time.swift-driver.wall	23.5s	23.4s	-41.7ms	-0.18%

release detailed

Regressed (0)

name	old	new	delta	delta_pct

Improved (2)

name	old	new	delta	delta_pct
Sema.NumDeclsDeserialized	32,490	32,000	-490	-1.51% ✅
Sema.NumLazyIterableDeclContexts	4,174	4,120	-54	-1.29% ✅

Unchanged (delta < 1.0% or delta < 100.0ms) (21)

name	old	new	delta	delta_pct
AST.NumImportedExternalDefinitions	402	402	0	0.0%
AST.NumLoadedModules	76	76	0	0.0%
AST.NumTotalClangImportedEntities	2,113	2,113	0	0.0%
AST.NumUsedConformances	886	886	0	0.0%
IRModule.NumIRBasicBlocks	20,943	20,943	0	0.0%
IRModule.NumIRFunctions	10,213	10,213	0	0.0%
IRModule.NumIRGlobals	8,088	8,088	0	0.0%
IRModule.NumIRInsts	220,344	220,344	0	0.0%
IRModule.NumIRValueSymbols	17,445	17,445	0	0.0%
LLVM.NumLLVMBytesOutput	7,275,652	7,275,780	128	0.0%
SILModule.NumSILGenFunctions	4,180	4,180	0	0.0%
SILModule.NumSILOptFunctions	5,854	5,854	0	0.0%
Sema.NumConformancesDeserialized	12,287	12,287	0	0.0%
Sema.NumConstraintScopes	40,650	40,650	0	0.0%
Sema.NumDeclsValidated	7,874	7,874	0	0.0%
Sema.NumFunctionsTypechecked	2,204	2,204	0	0.0%
Sema.NumGenericSignatureBuilders	1,710	1,710	0	0.0%
Sema.NumLazyGenericEnvironments	6,821	6,781	-40	-0.59%
Sema.NumLazyGenericEnvironmentsLoaded	130	130	0	0.0%
Sema.NumTypesDeserialized	18,156	18,146	-10	-0.06%
Sema.NumTypesValidated	5,972	5,972	0	0.0%

moiseev · 2019-01-26T05:16:00Z

@swift-ci Please test

swift-ci · 2019-01-26T05:18:02Z

Build failed
Swift Test Linux Platform
Git Sha - 01e1c6ef4d517cec95e67ad71f10b50e8ee99c2f

swift-ci · 2019-01-26T05:18:11Z

Build failed
Swift Test OS X Platform
Git Sha - 01e1c6ef4d517cec95e67ad71f10b50e8ee99c2f

moiseev · 2019-01-26T18:34:20Z

@swift-ci Please test macOS platform

swift-ci · 2019-01-26T20:08:58Z

Build failed
Swift Test OS X Platform
Git Sha - 240be2d0e30241c2c4fbfca9ba7d4c62ee266e51

moiseev · 2019-01-28T17:46:21Z

@swift-ci Please test macOS platform

swift-ci · 2019-01-28T19:22:04Z

Build failed
Swift Test OS X Platform
Git Sha - 240be2d0e30241c2c4fbfca9ba7d4c62ee266e51

moiseev · 2019-01-28T22:17:14Z

@swift-ci Please test

swift-ci · 2019-01-28T22:19:23Z

Build failed
Swift Test Linux Platform
Git Sha - 240be2d0e30241c2c4fbfca9ba7d4c62ee266e51

swift-ci · 2019-01-28T22:21:00Z

Build failed
Swift Test OS X Platform
Git Sha - 240be2d0e30241c2c4fbfca9ba7d4c62ee266e51

moiseev · 2019-01-28T22:21:54Z

@swift-ci Please test

swift-ci · 2019-01-28T22:24:06Z

Build failed
Swift Test Linux Platform
Git Sha - 046aa398e72b375c741c1ac9c55a1d1881115d7d

swift-ci · 2019-01-28T22:32:53Z

Build failed
Swift Test OS X Platform
Git Sha - 046aa398e72b375c741c1ac9c55a1d1881115d7d

jrose-apple · 2019-01-28T22:33:00Z

stdlib/public/core/Integers.swift

-      message: "Please use 'FixedWidthInteger' instead of 'SignedInteger' to get '&-' in generic code.")
-  public static func &- (lhs: Self, rhs: Self) -> Self {
-    return _maskingSubtract(lhs, rhs)
-  }


Some of these things are here to help when people type the wrong thing. Are you sure it's worth removing them?

Yeah, that was when SignedInteger implied a fixed-width-integer-ness, which has not been the case for more than a year now, so I'd say, yes.

xedin · 2019-01-28T23:13:21Z

moiseev · 2019-01-29T00:40:29Z

@swift-ci Please test

swift-ci · 2019-01-29T00:42:34Z

Build failed
Swift Test Linux Platform
Git Sha - 75e6f45b73e06b3949c6311572ff2dd165fb40ef

swift-ci · 2019-01-29T02:02:26Z

Build failed
Swift Test OS X Platform
Git Sha - 75e6f45b73e06b3949c6311572ff2dd165fb40ef

moiseev · 2019-01-29T19:15:53Z

apple/swift-lldb#1255
@swift-ci Please smoke test

moiseev · 2019-01-30T00:47:03Z

@swift-ci Please smoke test

moiseev · 2019-01-30T19:00:47Z

@swift-ci Please test macOS platform

swift-ci · 2019-01-30T19:03:03Z

Build failed
Swift Test OS X Platform
Git Sha - a367e33032731afd418e5810d359acc661d1607c

benrimmington · 2019-02-01T13:53:01Z

Should the LazySequenceProtocol.flatMap(_:) also be obsoleted?

What's the current status of PlaygroundQuickLook and CustomPlaygroundQuickLookable?

moiseev · 2019-02-01T19:03:32Z

Should the LazySequenceProtocol.flatMap(_:) also be obsoleted?

Go for it. obsoleted: 5.1 seems to be a reasonable guess for a next version.

As for the quicklookables, the majority of that stuff is already marked as obsoleted in Swift 5.0, the rest for some reason wasn't. Do you mind trying to mark it as obsolete in 5.1 and see what breaks?
/cc @airspeedswift

benrimmington · 2019-02-22T18:45:32Z

@moiseev My current iMac isn't supported by macOS Mojave, so I won't be able to build and test the above changes (to flatMap and quicklookables) by March 18th.

moiseev · 2019-02-22T19:06:53Z

It doesn't look like a pressing issue at the moment. All the APIs we're talking about are marked as deprecated now and the don't have to be obsoleted in 5.0 anyway. Besides, CI can help figure out what breaks :-)

moiseev · 2019-02-22T19:12:11Z

Let's try that flatMap first, shall we? #22817

moiseev changed the title ~~[stdlib] Remove a bunch opf declarations marked as obsoleted in 4~~ [stdlib] Remove a bunch of declarations marked as obsoleted in 4 Jan 25, 2019

moiseev force-pushed the spring-cleaning branch 2 times, most recently from ea6f7fc to 01e1c6e Compare January 25, 2019 23:54

xedin reviewed Jan 25, 2019

View reviewed changes

moiseev force-pushed the spring-cleaning branch from 240be2d to 046aa39 Compare January 28, 2019 22:16

moiseev force-pushed the spring-cleaning branch from 046aa39 to 75e6f45 Compare January 28, 2019 22:21

jrose-apple reviewed Jan 28, 2019

View reviewed changes

moiseev force-pushed the spring-cleaning branch from 75e6f45 to a367e33 Compare January 29, 2019 00:39

moiseev mentioned this pull request Jan 29, 2019

Use compactMap apple/swift-lldb#1255

Closed

moiseev added 2 commits January 29, 2019 11:13

[stdlib] Remove a bunch of declarations marked as obsoleted in 4

02cc225

List removals in ABI expected breakage test

b3e883b

moiseev force-pushed the spring-cleaning branch from a367e33 to cda1e59 Compare January 29, 2019 19:15

moiseev added 2 commits January 29, 2019 16:26

Uncomment 'obsoleted: 5.0' on a flatMap variant

d003072

Remove obsolete tests from FixedPointDiagnostics (again)

9a81ac7

moiseev force-pushed the spring-cleaning branch from cda1e59 to 9a81ac7 Compare January 30, 2019 00:46

moiseev merged commit 556e089 into swiftlang:master Feb 1, 2019

moiseev deleted the spring-cleaning branch February 1, 2019 19:03

[stdlib] Remove a bunch of declarations marked as obsoleted in 4 #22138

[stdlib] Remove a bunch of declarations marked as obsoleted in 4 #22138

Uh oh!

Conversation

moiseev commented Jan 25, 2019

Uh oh!

moiseev commented Jan 25, 2019

Uh oh!

moiseev commented Jan 25, 2019

Uh oh!

xedin Jan 25, 2019

Choose a reason for hiding this comment

Uh oh!

moiseev commented Jan 25, 2019

Uh oh!

swift-ci commented Jan 25, 2019

Uh oh!

swift-ci commented Jan 25, 2019

Uh oh!

swift-ci commented Jan 26, 2019

Build comment file:

Summary for master smoketest

Debug

debug brief

debug detailed

Release

release brief

release detailed

Uh oh!

moiseev commented Jan 26, 2019

Uh oh!

swift-ci commented Jan 26, 2019

Uh oh!

swift-ci commented Jan 26, 2019

Uh oh!

moiseev commented Jan 26, 2019

Uh oh!

swift-ci commented Jan 26, 2019

Uh oh!

moiseev commented Jan 28, 2019

Uh oh!

swift-ci commented Jan 28, 2019

Uh oh!

moiseev commented Jan 28, 2019

Uh oh!

swift-ci commented Jan 28, 2019

Uh oh!

swift-ci commented Jan 28, 2019

Uh oh!

moiseev commented Jan 28, 2019

Uh oh!

swift-ci commented Jan 28, 2019

Uh oh!

swift-ci commented Jan 28, 2019

Uh oh!

jrose-apple Jan 28, 2019

Choose a reason for hiding this comment

Uh oh!

moiseev Jan 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xedin commented Jan 28, 2019

Uh oh!

moiseev commented Jan 29, 2019

Uh oh!

swift-ci commented Jan 29, 2019

Uh oh!

swift-ci commented Jan 29, 2019

Uh oh!

moiseev commented Jan 29, 2019

Uh oh!

moiseev commented Jan 30, 2019

Uh oh!

moiseev commented Jan 30, 2019

Uh oh!

swift-ci commented Jan 30, 2019

Uh oh!

benrimmington commented Feb 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

moiseev Jan 28, 2019 •

edited

Loading

benrimmington commented Feb 1, 2019 •

edited

Loading