Skip to content

[5.0] Remove declarations obsoleted in Swift 4 #22139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 27, 2019
Merged

[5.0] Remove declarations obsoleted in Swift 4 #22139

merged 5 commits into from
Jan 27, 2019

Conversation

moiseev
Copy link
Contributor

@moiseev moiseev commented Jan 26, 2019

No description provided.

@moiseev moiseev requested a review from a team as a code owner January 26, 2019 00:09
airspeedswift and others added 4 commits January 25, 2019 16:10
@airspeedswift @moiseev
Remove a couple of obsoleted-in-4.0 methods
b3068af 
(cherry picked from commit 80f0a69)
@airspeedswift @moiseev
Add (false positive) removals to ABI checker file
78a0129 
(cherry picked from commit 72c0006)
@moiseev
[stdlib] Remove a bunch of declarations marked as obsoleted in 4
3ab3f99 
(cherry picked from commit 54e79e2f2b4c9997881aae10f1947d8e667595ee)
@moiseev
List removals in ABI expected breakage test
e1dccb3 
(cherry picked from commit 01e1c6ef4d517cec95e67ad71f10b50e8ee99c2f)
@moiseev
Copy link
Contributor Author

moiseev commented Jan 26, 2019

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - e1dccb3

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - e1dccb3

Update the validation test
e5f82db 
(cherry picked from commit 240be2d0e30241c2c4fbfca9ba7d4c62ee266e51)
@moiseev
Copy link
Contributor Author

moiseev commented Jan 26, 2019

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - e1dccb3

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - e1dccb3

@moiseev
Copy link
Contributor Author

moiseev commented Jan 26, 2019

@swift-ci Please test macOS platform

@airspeedswift airspeedswift merged commit ab16446 into swiftlang:swift-5.0-branch Jan 27, 2019
@moiseev moiseev deleted the obsoleted-in-4-5 branch January 28, 2019 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airspeedswift airspeedswift airspeedswift approved these changes

Assignees

@airspeedswift airspeedswift

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moiseev @swift-ci @airspeedswift