test: adjust Frontend tests for Windows #22154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust some of the tests to improve the pass rate on Windows. This involves using less shell syntax, quoting instead of escaping slashes and accepting the windows path separator.
|
@swift-ci please test |
|
CC: @jrose-apple @CodaFi |
|
Build failed |
|
@swift-ci please test macOS platform |
|
Build failed |
jrose-apple
approved these changes
Jan 28, 2019
| @@ -1,6 +1,8 @@ | |||
| // RUN: %empty-directory(%t) | |||
| // RUN: echo 'print("Hello, World!")' >%t/main.swift | |||
| // RUN: touch %t/file-01.swift | |||
| // RUN: (cd %t && not %target-swift-frontend -parse -primary-file main.swift -primary-file file-01.swift -supplementary-output-file-map %S/Inputs/supplementary_output_filemap_missing_a_primary.yaml >%t/errs.txt 2>&1) | |||
| // RUN: cd %t | |||
There was a problem hiding this comment.
I'm really happy this works now; it used to not.
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust some of the tests to improve the pass rate on Windows. This
involves using less shell syntax, quoting instead of escaping slashes
and accepting the windows path separator.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.