[build-script] Tests should fail if one of test commands failed. #2217
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test and merge |
|
Good! It seems, this change unveiled a hidden problem 😁 Failed on compiling |
|
I believe the problem is resolved in #2327. |
|
@swift-ci Please test and merge |
|
@rintaro Could you take a look at the buildbot failure? https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-14_04-long-test/60/console |
|
I'm looking into it. |
|
First of all, some build commands are assuming ${PWD} is the build directory. should resolve the current problem... But, I think, the root cause is that the test dependencies are not fully built before tests execution. |
|
I agree, that command shouldn't be building anything, looks like we are missing some dependencies. |
Long test implies |
|
Yes, I think it should be the full library. |
|
Testing: --- a/utils/build-script-impl
+++ b/utils/build-script-impl
@@ -1083,7 +1083,7 @@ for deployment_target in "${STDLIB_DEPLOYMENT_TARGETS[@]}"; do
if [[ "${BUILD_SWIFT_STDLIB_UNITTEST_EXTRA}" == "1" ]] ; then
SWIFT_STDLIB_TARGETS+=("swift-stdlib-${deployment_target}")
else
- if [[ "${VALIDATION_TEST}" == "1" ]] ; then
+ if [[ "${VALIDATION_TEST}" == "1" || "${LONG_TEST}" == "1" ]] ; then
SWIFT_STDLIB_TARGETS+=("swift-stdlib-${deployment_target}")
else
SWIFT_STDLIB_TARGETS+=("swift-test-stdlib-${deployment_target}") |
|
Passed locally. Could you try apply that and wait the bot? |
|
@rintaro Mind submitting a PR? I'll accept immediately. |
|
Sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Test script:
should be considered as failed, and
trueshould never be executed.Use
-eoption for test script execution:sh -e -x -c "script.."Before merging this pull request to apple/swift repository: