[5.0][Sema] Add dedicated fix-it for NSObject.hashValue overrides #22173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NSObject.hashValue used to be declared `@objc open` by historical accident. This has been corrected to `@nonobjc public` in Swift 5’s SDK overlays, to catch accidental overrides. (These never did work correctly, and shouldn’t have been allowed.) Help migration by adding a dedicated error message for NSObject.hashValue overrides, with a nice fix-it. rdar://problem/45674813 (cherry picked from commit df8eba4)
(cherry picked from commit 6af814d)
|
@swift-ci test |
airspeedswift
approved these changes
Jan 28, 2019
|
@swift-ci please nominate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Cherry-picked from #22081)
Explanation: Adds a fix-it to help migrating NSObject.hashValue overrides to the correct property, NSObject.hash.
Scope: Limited to compiler diagnostics.
Issue: rdar://problem/45674813
Risk: Low.
Testing: Local and CI testing on master, including newly added tests for the fix-it functionality.
Reviewed by: @jrose-apple (#22081)