[Diagnostics] Mark invalid ‘@testable import’ as fatal #22191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still needs a test. |
harlanhaskins
force-pushed
the
fatality
branch
from
8964adf to
7ce440d
Compare
|
@jrose-apple I added a test (was not aware -verify doesn't handle fatal errors!) |
jrose-apple
approved these changes
Jan 29, 2019
|
@swift-ci please smoke test |
harlanhaskins
force-pushed
the
fatality
branch
from
7ce440d to
997c677
Compare
|
@swift-ci please smoke test |
jrose-apple
reviewed
Jan 29, 2019
| @testable import Swift // expected-error {{module 'Swift' was not compiled for testing}} | ||
| // CHECK: module 'Swift' was not compiled for testing | ||
| // DISABLED-NOT: module 'Swift' was not compiled for testing | ||
| @testable import Swift | ||
| @testable import empty // no-error | ||
| @testable import Testable_ClangModule // no-error |
There was a problem hiding this comment.
Now these aren't being checked anymore.
There was a problem hiding this comment.
How about now? I'm trying to be a bit more explicit than before.
If this isn’t fatal, this will just end up cascading to a bunch of “could not find member … in …” errors, which hides the real issue.
harlanhaskins
force-pushed
the
fatality
branch
from
997c677 to
f4b0e0e
Compare
jrose-apple
approved these changes
Jan 29, 2019
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this isn’t fatal, this will just end up cascading to a bunch of “could not find member … in …” errors, which hides the real issue.