Disable TSan in coroutine functions #22222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test. |
rjmccall
changed the title
devincoughlin
approved these changes
Jan 29, 2019
lib/IRGen/IRGenSIL.cpp
Outdated
| // Do not report races in deinit and anything called from it | ||
| // because TSan does not observe synchronization between retain | ||
| // count dropping to '0' and the object deinitialization. | ||
| // Also don't report races in coroutines because the instrumentation |
There was a problem hiding this comment.
I think this comment "Also don't report races in coroutines..." is misplaced since we're not using "sanitize_thread_no_checking_at_run_time" for coroutines. Can we just remove the comment?
There was a problem hiding this comment.
Yes, sorry, that was a legacy of a previous version of this commit in which the cases were merged.
There was a problem hiding this comment.
I will upload a new version of the patch after this one (presumably) passes the full test suite.
|
Thanks! |
Fixes rdar://47491307. I've filed rdar://47642395 to track re-enabling TSan in coroutines.
rjmccall
force-pushed
the
disable-tsan-in-coroutines
branch
from
eec8466 to
0ca3f79
Compare
|
@swift-ci Please smoke test. |
|
Passed full test suite, re-running smoke tests with comment change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://47491307.
I've filed rdar://47642395 to track re-enabling TSan in coroutines.