Type reconstruction rework, part 3 #22237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…C classes MetadataLookup gives special treatment to imported Objective-C classes, since there's no nominal type descriptor and metadata is obtained directly by calling into the Objective-C runtime. Remote reflection also gives special treatment to imported Objective-C classes; they don't have field descriptors. However, the ASTDemangler needs to treat them like ordinary classes, in particular it wants to preserve the generic arguments here so that we can round-trip debug info.
For now this just duplicates mangleTypeForDebugger(), but the latter's behavior is going to change.
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
DougGregor
approved these changes
Jan 30, 2019
|
Build failed |
|
@swift-ci Please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #22185. Fixes two more round-tripping bugs in the demangler, and changes the mangler to preserve protocol names in dependent member types when mangling for debug info. This required a bit of refactoring since we also use this mangling for local type names in serialized modules.
Progress on rdar://problem/41115104..