-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Fix ExistentialSpecializer: Recursive function specialization #22247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change seems fine. I want to set better precedent with the style of test though. The biggest difficulty in changing SIL today is knowing how to update all the CHECK lines without understanding the original intention. I think this should be a .sil test and it needs a comment to explain the bailout that it exercises.
1529c0f
to
87bf79d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@atrick I added a sil test case. the primary goal for both swift and sil test cases are that they check for signatures and hence function_ref instructions are fully checked.
Please review when you get a chance.
40d6600
to
70ac1b2
Compare
@atrick please run tests. I have addressed all your concerns. |
@swift-ci test. |
@rajbarik is the "Stable with ES in open source" commit supposed to be in this PR. I don't remember reviewing that. |
Build failed |
Build failed |
Some git mess. Let me fix this. |
70ac1b2
to
6d9f532
Compare
@atrick fixed. |
@atrick please run tests here again. Thanks. |
@swift-ci test. |
@atrick any idea why this is not reporting anything for last 3 days? |
Build failed |
@atrick please advise. I do not any logs for Swift Test Linux Platform. |
@swift-ci test linux platform. |
This PR fixes a bug in ExistentialSpecializer where a recursive function when specialized crashed the compiler. I have attached a test case with the PR.