Skip to content

[5.0][CSDiagnostics] NFC: Fallback diagnostic shouldn't ask for the project #22254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2019
Merged

[5.0][CSDiagnostics] NFC: Fallback diagnostic shouldn't ask for the project #22254

merged 1 commit into from
Feb 1, 2019

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Jan 31, 2019

(cherry picked from commit 5202468)

@xedin xedin requested a review from AnnaZaks January 31, 2019 01:39
@xedin xedin requested a review from a team as a code owner January 31, 2019 01:39
@xedin
Copy link
Contributor Author

xedin commented Jan 31, 2019

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - c69d79c

@xedin
Copy link
Contributor Author

xedin commented Jan 31, 2019

@swift-ci please test Linux platform

@AnnaZaks AnnaZaks merged commit 29040d4 into swiftlang:swift-5.0-branch Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnnaZaks AnnaZaks AnnaZaks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xedin @swift-ci @AnnaZaks