[benchmark] DataCreateSmall - Fix legacyFactor

[palimondo]

Adjust the multipliers for legacy factor and inner loop to account for the improved performance of the Data implementation.

[palimondo]

@swift-ci please benchmark

[palimondo]

@swift-ci please smoke test

[swift-ci]

Build comment file:

Performance: -O

TEST	OLD	NEW	DELTA	RATIO
Regression
DataCreateSmall	2000	2560	+28.0%	0.78x (?)

Performance: -Osize

TEST	OLD	NEW	DELTA	RATIO
Regression
DataCreateSmall	2000	2690	+34.5%	0.74x

Performance: -Onone

TEST	OLD	NEW	DELTA	RATIO
Improvement
DataAppendArray	4900	4500	-8.2%	1.09x (?)

How to read the data

The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview

  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 8-Core Intel Xeon E5
  Processor Speed: 3 GHz
  Number of Processors: 1
  Total Number of Cores: 8
  L2 Cache (per Core): 256 KB
  L3 Cache: 25 MB
  Memory: 64 GB

--------------

[palimondo]

@swift-ci please smoke test OS X

[palimondo]

@eeckstein Please review 🙏

[palimondo]

@eeckstein This was super trivial change. The reported times were fluctuating between 2 and 3 μs since the faster Data implementation landed. I went ahead and merged the fix without your review, so that it stops showing up as false change.

[eeckstein]

ok, no problem