[Benchmark] Benchmark UTF8 decoding from typed & untyped bufferys #22277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eeckstein I don't know how you want to handle these plethora of micro-variations in micro-benchmarks. Ideally, we'd do more LIT-style tests for these. |
|
@karwa Can you rebase your benchmark and we'll get this run? |
|
I'm going to close this out due to age and inactivity. If you still wish to pursue this, please reopen this pull request and rebase it to fix the conflict. Thanks! |
|
I think this is covered by other tests that have been added since this PR was opened. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions are generic, so we should test more than just Array, for which
Array(genericCollection)which never copy, even in specialised generic code.CC @milseman