Skip to content

[5.0] sourcekitd/format: avoid performing sibling-based indentation for PrefixUnaryExpr. #22287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2019

Conversation

nkcsgexi
Copy link
Contributor

@nkcsgexi nkcsgexi commented Feb 1, 2019

rdar://47659949

@nkcsgexi nkcsgexi requested a review from a team as a code owner February 1, 2019 00:51
@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Feb 1, 2019

@swift-ci please test

@@ -575,8 +575,12 @@ class FormatWalker : public SourceEntityWalker {
};

if (auto AE = dyn_cast_or_null<ApplyExpr>(Node.dyn_cast<Expr *>())) {
collect(AE->getArg());
return;
// PrefixUnaryExpr shouldn't be syntacticly considered as a funtion call
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: funtion -> function

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix on master

@akyrtzi akyrtzi merged commit d2f60e6 into swiftlang:swift-5.0-branch Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants