Skip to content

utils: adjust to support long paths on windows #22332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2019

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Feb 3, 2019

Windows restricts paths to 251 characters. Using unicode paths will
allow us to go down the _wfopen path which permits the use of the NT
path to actually use long paths.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@compnerd
Copy link
Member Author

compnerd commented Feb 3, 2019

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Feb 3, 2019

Build failed
Swift Test Linux Platform
Git Sha - 626e787313a941e4c4c0e8883fb044fff7c68dc7

@swift-ci
Copy link
Contributor

swift-ci commented Feb 3, 2019

Build failed
Swift Test OS X Platform
Git Sha - 626e787313a941e4c4c0e8883fb044fff7c68dc7

@compnerd
Copy link
Member Author

compnerd commented Feb 4, 2019

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Feb 4, 2019

Build failed
Swift Test OS X Platform
Git Sha - f571d98c8fff634a96eaa95c5030f8a3f0bed729

@compnerd
Copy link
Member Author

compnerd commented Feb 4, 2019

@swift-ci please test macOS platform

@swift-ci
Copy link
Contributor

swift-ci commented Feb 4, 2019

Build failed
Swift Test OS X Platform
Git Sha - f571d98c8fff634a96eaa95c5030f8a3f0bed729

Windows restricts paths to 251 characters.  Using unicode paths will
allow us to go down the `_wfopen` path which permits the use of the NT
path to actually use long paths.
@compnerd
Copy link
Member Author

compnerd commented Feb 4, 2019

@swift-ci please test

@compnerd compnerd merged commit 0919b1b into swiftlang:master Feb 4, 2019
@compnerd compnerd deleted the long-long-long branch February 4, 2019 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants