Skip to content

[LoadableByAddress] handle functions that return a closure in a tuple #22362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2019

Conversation

shajrawi
Copy link

@shajrawi shajrawi commented Feb 5, 2019

Fixes https://bugs.swift.org/browse/SR-9849

If we have a tuple-creation instruction that takes in a large type, we have to re-create it because the 'stale' saved type is no longer correct. said stale type is propagated to return instructions which will have an invalid type.

@shajrawi
Copy link
Author

shajrawi commented Feb 5, 2019

@swift-ci Please test

@shajrawi
Copy link
Author

shajrawi commented Feb 5, 2019

cc @rxwei

@shajrawi
Copy link
Author

shajrawi commented Feb 5, 2019

@swift-ci Please test

@swiftlang swiftlang deleted a comment from swift-ci Feb 5, 2019
@shajrawi shajrawi merged commit fe59328 into swiftlang:master Feb 5, 2019
@shajrawi shajrawi deleted the sr9849 branch February 5, 2019 18:36
@aschwaighofer
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants