-
Notifications
You must be signed in to change notification settings - Fork 10.5k
ASTPrinter: add an option to skip keywords with an underscore prefix #22365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci please smoke test |
I think we should hide them from interface generation in general (disable in |
Looks fine to me. Can you add a test to make sure we don't ever set this to true for parseable interfaces? We always want to print these in parseable interfaces. |
@harlanhaskins what kind of test do you have in mind? We should have existing tests to ensure parseable interface handles underscored attributes, right? |
Maybe i could add an assertion at the entry point of parseable interface generation? |
Alternatively, could you set it explicitly in |
@harlanhaskins sure, will do |
@akyrtzi @harlanhaskins Code review comments addressed. Function |
@swift-ci please smoke test |
I think we were deliberately printing these. @airspeedswift? |
Discussed with @airspeedswift and he is fine with hiding them from documentation but would like them to be present in the generated interface. |
@airspeedswift @akyrtzi The latest commit moved the flag back to documentation generation option so that we won't skip them in the generated interface from IDE. |
@swift-ci please smoke test |
@swift-ci Please smoke test OS X Platform |
DocSupport will use set this flag to avoid printing __consuming, __owned, and __shared. rdar://47777848
…ting module interface.
Addressing @airspeedswift's code review feedback.
@swift-ci please smoke test |
DocSupport will use set this flag to avoid printing __consuming, __owned, and __shared.
rdar://47777848