Skip to content

[SILProfiler] Set up profiling for lazily-emitted functions #22403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2019

Conversation

vedantk
Copy link
Contributor

@vedantk vedantk commented Feb 6, 2019

A SIL function that's initially only emitted as a declaration may later
be prepared for definition. When this happens, set up a profiler for the
definition.

This makes code coverage visible for private methods (the frontend
follows a declare-then-define pattern for these).

rdar://47759243

A SIL function that's initially only emitted as a declaration may later
be prepared for definition. When this happens, set up a profiler for the
definition.

This makes code coverage visible for private methods (the frontend
follows a declare-then-define pattern for these).

rdar://47759243
@vedantk
Copy link
Contributor Author

vedantk commented Feb 6, 2019

@swift-ci please smoke test

@vedantk
Copy link
Contributor Author

vedantk commented Feb 6, 2019

Bots have been failing with:
swift/stdlib/public/Darwin/QuartzCore/NSValue.swift.gyb:33:50: error: use of undeclared type 'Type'

@vedantk
Copy link
Contributor Author

vedantk commented Feb 6, 2019

@swift-ci please smoke test

@vedantk vedantk merged commit a9da803 into swiftlang:master Feb 6, 2019
@vedantk vedantk deleted the profile-lazy-defs branch February 6, 2019 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants