Extend transitive availability checking to initial value expressions #22438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because initial value expressions aren't actually considered /within/ the VarDecl or PatternBindingDecl they're initializing, the existing logic to search for availability attributes wasn't kicking in, leading to errors when a conditionally-unavailable value was used in an initial value expression for a conditionally-unavailable binding. https://bugs.swift.org/browse/SR-9867
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
slavapestov
approved these changes
Feb 7, 2019
beccadax
approved these changes
Feb 7, 2019
| var osx_init_osx = osx() // OK | ||
|
|
||
| @available(OSXApplicationExtension, unavailable) | ||
| var osx_extension_init_osx = osx() // expected-error {{'osx()' is unavailable}} |
There was a problem hiding this comment.
Would this test pass?
@available(OSX, unavailable)
var osx_inner_init_osx = { let inner_var = osx() }If so, is it worth adding to the test suite? If not, do we want to merge this change anyway?
There was a problem hiding this comment.
Definitely seems worth adding! I think it'll work with this change, but it's always worth checking.
There was a problem hiding this comment.
Aha, it does not work. Important info!
There was a problem hiding this comment.
I'm going to look at this this afternoon, and if there's not an easy fix maybe we'll just take this part.
|
Found a better approach, will open a new PR for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because initial value expressions aren't actually considered within the VarDecl or PatternBindingDecl they're initializing, the existing logic to search for availability attributes wasn't kicking in, leading to errors when a conditionally-unavailable value was used in an initial value expression for a conditionally-unavailable binding.
SR-9867 / rdar://problem/47852718