Skip to content

[ConstraintSystem] Detect invalid implicit ref to initializer on non-… #22442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Feb 7, 2019

…const metatype

Situations like:

struct S {}
func foo(_ s: S.Type) {
  _ = s()
}

Used to be diagnosed in solution application phase, which means that
solver was allowed to formed an incorrect solution.

…const metatype

Situations like:

```swift
struct S {}
func foo(_ s: S.Type) {
  _ = s()
}
```

Used to be diagnosed in solution application phase, which means that
solver was allowed to formed an incorrect solution.
@xedin xedin requested a review from slavapestov February 7, 2019 08:33
@xedin
Copy link
Contributor Author

xedin commented Feb 7, 2019

@slavapestov This is one of the diagnostics you mentioned in #22124

I'm working on the follow-up PR to speed-up findResolvedMemberRef because it's use has been extended to solver itself now and not just diagnostics.

@xedin
Copy link
Contributor Author

xedin commented Feb 7, 2019

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented Feb 7, 2019

@swift-ci please test source compatibility

@xedin xedin merged commit 2ea00c3 into swiftlang:master Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant