IDE: Remove getTypeFromMangledSymbolname() #22470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
There was only one remaining usage other than in testing tools. Note that when a declaration mangling was passed in, the old entry point would (try to) return the type of the declaration. The new entry point no longer has this behavior. I changed the bridging-header-first test to run lldb-moduleimport-test with -decl-from-mangled instead of -type-from-mangled-old to preserve the behavior of the test. Also, I removed test/DebugInfo/DumpTypeFromMangledName.swift completely. This test only covered a handful of cases, and a bunch of them were declaration manglings rather than type manglings. The new tests in test/TypeDecoder/ are much more comprehensive.
slavapestov
force-pushed
the
remove-type-reconstruction-part-1
branch
from
836256f to
b2f0327
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was only one remaining usage other than in testing tools.
Note that when a declaration mangling was passed in, the old entry
point would (try to) return the type of the declaration.
The new entry point no longer has this behavior. I changed the
bridging-header-first test to run lldb-moduleimport-test with
-decl-from-mangled instead of -type-from-mangled-old to preserve
the behavior of the test.
Also, I removed test/DebugInfo/DumpTypeFromMangledName.swift
completely. This test only covered a handful of cases, and a bunch
of them were declaration manglings rather than type manglings.
The new tests in test/TypeDecoder/ are much more comprehensive.
Fixes rdar://problem/44681502.