Skip to content

IRGen: Don't output the full file path in the withoutActuallyEscaping… #22479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2019
Merged

IRGen: Don't output the full file path in the withoutActuallyEscaping… #22479

merged 1 commit into from
Feb 11, 2019

Conversation

aschwaighofer
Copy link
Contributor

… verification

At Odebug we will now print only the file name (not the full path to the
file) and in optimized mode no file name will be included.

This mirrors what we do in Swift's asserts.

rdar://47880964

@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test

@jrose-apple
Copy link
Contributor

I believe assertions generally do print the full filename (though people are talking about changing #file to do something else).

@aschwaighofer
Copy link
Contributor Author

@jrose-apple You are right. I just happened to test swiftc filename.swift.

@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Feb 8, 2019

Build failed
Swift Test Linux Platform
Git Sha - f28c2f5feb41e4999c97cf971c068e1344b6da43

@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 637818ab94321446c88dd3ff27f5de137ecb48a8

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 637818ab94321446c88dd3ff27f5de137ecb48a8

@aschwaighofer
IRGen: Don't output the full file path in the noescape closure verifi…
9212cbf 
…cation

At Odebug we print the full path to the file and in optimized mode no
file name will be included.

This mirrors what we do in Swift's asserts.

rdar://47880964
@aschwaighofer aschwaighofer force-pushed the no_path_in_closure_verification branch from 637818a to 9212cbf Compare February 11, 2019 17:01
@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 637818ab94321446c88dd3ff27f5de137ecb48a8

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 637818ab94321446c88dd3ff27f5de137ecb48a8

@aschwaighofer aschwaighofer merged commit b41f441 into swiftlang:master Feb 11, 2019
@pointum
Copy link

pointum commented Mar 28, 2019

@aschwaighofer should this be fixed in Swift 5.0 / Xcode 10.2? My test steps still emit a full path in an optimized build: SR-9895

@aschwaighofer
Copy link
Contributor Author

No this change is not in Xcode 10.2

@theblixguy theblixguy mentioned this pull request Feb 9, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shajrawi shajrawi shajrawi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aschwaighofer @jrose-apple @swift-ci @pointum @shajrawi