[ConstraintSystem] Diagnose conditional requirement failures via fixes #22480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quirement locator
Extend existing `RequirementFailure` functionality to support conditional requirement failures. Such fixes are introduced only if the parent type requirement has been matched successfully. Resolves: rdar://problem/47871590
xedin
commented
Feb 8, 2019
slavapestov
approved these changes
Feb 8, 2019
| @@ -338,7 +339,7 @@ extension Int: P { } | |||
|
|
|||
| func testConditional(i: Int, s: String) { | |||
| let _: PArray<Int> = [i, i, i] | |||
| let _: PArray<String> = [s, s, s] // expected-error{{cannot convert value of type '[String]' to specified type 'PArray<String>'}} | |||
| let _: PArray<String> = [s, s, s] // expected-error{{generic struct 'PArray' requires that 'String' conform to 'P'}} | |||
If affected declaration is a static or instance memeber (excluding operators) and failed requirement is declared in other nominal type or extension, diagnose such problems as `in reference` instead of claiming that requirement belongs to the member itself.
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test Linux platform |
|
Build failed |
|
Build failed |
|
@shahmishal Looks like this is something with the bot itself in the final phase. |
|
@swift-ci please test |
| // expected-note@-1 {{candidate requires that the types 'U' and 'V' be equivalent (requirement specified as 'U' == 'V')}} | ||
| // expected-note@-2 {{requirement from conditional conformance of 'SameTypeGeneric<U, V>' to 'P2'}} | ||
| // expected-note@-3 {{requirement from conditional conformance of 'SubclassBad' to 'P2'}} | ||
| // expected-note@-4 {{candidate requires that 'C1' inherit from 'U' (requirement specified as 'U' : 'C1')}} |
There was a problem hiding this comment.
Should this read candidate requires that 'U' inherit from 'C1'?
There was a problem hiding this comment.
Yeah, probably, I didn't touch existing messages in declaration checker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend existing
RequirementFailurefunctionality to supportconditional requirement failures. Such fixes are introduced
only if the parent type requirement has been matched successfully.
Resolves: rdar://problem/47871590