[Sema] Remove lookupBoolType #22488
[Sema] Remove lookupBoolType #22488
Conversation
|
|
||
| auto tyDecl = dyn_cast<NominalTypeDecl>(results.front()); | ||
| if (!tyDecl) { | ||
| diagnose(SourceLoc(), diag::broken_bool); |
There was a problem hiding this comment.
If we're not going to bother diagnosing this anymore, you can remove the diagnostic too.
There was a problem hiding this comment.
We use this diagnostic elsewhere in TypeCheckDeclObjC and with Bool.init(_builtinBooleanLiteral:) in CSApply
There was a problem hiding this comment.
Although arguably the last one could be its own diagnostic. These broken diagnostics are something I want to improve in the future however.
There was a problem hiding this comment.
I think the 'broken stdlib' diagnostics should become fatal. Parts of the compiler don't recover well from these and assert later, so we may as well just exit early when it happens.
There was a problem hiding this comment.
Are you suggesting something like llvm_unreachable for these 'broken stdlib' diagnostics?
There was a problem hiding this comment.
I definitely have run into cases where the failures are pretty terrible and at times you just get weird things like the literal doesn't conform to equatable or some equally odd until you look through and find special look ups in the compiler.
There was a problem hiding this comment.
I think for this patch I'll go ahead and add back the diagnostic, but in a follow up I'll fix up these broken diagnostics to be fatal.
Azoy
force-pushed
the
remove-lookupBoolType
branch
from
d1d06ee to
a9f3e40
Compare
diagnose broken bool fix
Azoy
force-pushed
the
remove-lookupBoolType
branch
from
a9f3e40 to
e9f4217
Compare
|
@swift-ci please smoke test |
|
@CodaFi Can you run CI again please? |
|
@swift-ci Please smoke test |
|
⛵️ |
No description provided.