[sil] Tighten up SIL verification around when checked_cast_br should/… #22503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shouldn't have failure arguments. checked_cast_br in ownership SIL funnels through the original value to the failure block as a SILArgument for cleanup purposes. In contrast, when SIL is not in ossa, we do not want the failure bb case to have any arguments since that is the pattern that SILOptimizer passes expect. This commit just formalizes these constraints into the SILVerifier to catch mistakes.
|
@swift-ci smoke test |
|
Going to run this through a test and then a source compatibility run (just in case). |
|
@swift-ci test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…shouldn't have failure arguments.
checked_cast_br in ownership SIL funnels through the original value to the
failure block as a SILArgument for cleanup purposes. In contrast, when SIL is
not in ossa, we do not want the failure bb case to have any arguments since that
is the pattern that SILOptimizer passes expect.
This commit just formalizes these constraints into the SILVerifier to catch
mistakes.