[ome] Eliminate inefficiencies in lowering of destructures to ensure -Onone output stays the same. #22506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e projections for used results. This is not technically necessary, but it eliminates some differences in the tests at -Onone.
|
@swift-ci smoke test |
|
I investigated the failure here. We are just emitting better code due to the simplification (specifically we are eliminating an unnecessary tuple_extract). I am going to update the test. |
|
(and put in a better pattern that is more descriptive about what is happening in the test) |
…possible. I noticed that this is needed at -Onone to maintain the same codegen output.
gottesmm
force-pushed
the
pr-1976b9749f89a8476a3c2744d1c8e2a758c40fdf
branch
from
cf86dea to
89a447a
Compare
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just fixing a few inefficiencies so that -Onone code output stays the same [and I can avoid needing to update certain tests ; )]. Specifically: