[gardening] Change an if-else over ApplySite to a covered switch over… #22519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test and merge |
gottesmm
force-pushed
the
pr-bafb507409a233c2b64c95d66aa152e937fe7b86
branch
from
ae2b406 to
ea9bcd9
Compare
… ApplySiteKind. This will ensure that we get covered switch warnings if a new apply site is ever added. NFC.
gottesmm
force-pushed
the
pr-bafb507409a233c2b64c95d66aa152e937fe7b86
branch
from
ea9bcd9 to
bc280ab
Compare
|
@swift-ci smoke test and merge |
3 similar comments
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test and merge |
|
The os x failure is due to a non-deterministic test that @slavapestov is fixing. I disabled it in #22523. @slavapestov will re-enable once he has the fix. |
|
@swift-ci smoke test os x platform |
1 similar comment
|
@swift-ci smoke test os x platform |
|
@swift-ci smoke test OS X platform |
|
@swift-ci smoke test os x platform |
5 similar comments
|
@swift-ci smoke test os x platform |
|
@swift-ci smoke test os x platform |
|
@swift-ci smoke test os x platform |
|
@swift-ci smoke test os x platform |
|
@swift-ci smoke test os x platform |
|
@swift-ci smoke test macOS platform |
|
@swift-ci smoke test macOS |
1 similar comment
|
@swift-ci smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… ApplySiteKind.
This will ensure that we get covered switch warnings if a new apply site is ever
added.
NFC.