Fix crashes in Unsafe[Raw]BufferPointer with nil baseAddress. #22521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix updates various initializers to handle incoming empty buffers that happen to have a nil base. They should simply create another buffer with nil base rather than crashing! It is valid for an Unsafe[Raw]BufferPointer can have a nil base address. This allows round-tripping with C code that takes a pointer/length pair and uses `0` as the pointer value. The original design wrongly assumed that we would use a sentinel value for empty buffers and was never updated for or tested with the current design. Fixes <rdar://problem/47946984> Regression in Foundation.Data's UnsafeBufferPointer constructor.
|
@swift-ci test. |
|
@swift-ci test source compatibility. |
|
@airspeedswift can you review this for 5.0? |
|
@itaiferber please review. |
airspeedswift
approved these changes
Feb 11, 2019
|
Thanks for addressing this! The changes look good to me. |
|
@itaiferber you might still want to add a test on the Foundation side. I just wanted to get this fix in quickly. |
|
@atrick Yep, once this is in I'll add a unit test on the Foundation side (filed 47978737) |
|
Build failed |
|
@swift-ci smoke test OSX platform. |
|
@swift-ci smoke test OS X platform. |
|
Been trying to get this through PR testing all afternoon. It appears to be blocked on #22534 |
|
@swift-ci smoke test OS X platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix updates various initializers to handle incoming empty buffers
that happen to have a nil base. They should simply create another
buffer with nil base rather than crashing!
It is valid for an Unsafe[Raw]BufferPointer can have a nil base
address. This allows round-tripping with C code that takes a
pointer/length pair and uses
0as the pointer value.The original design wrongly assumed that we would use a sentinel value
for empty buffers and was never updated for or tested with the current
design.
Fixes rdar://problem/47946984 Regression in Foundation.Data's
UnsafeBufferPointer constructor.